[xmlroff] g_option_context_set_summary and BSDs

Jeroen Ruigrok van der Werven asmodai at in-nomine.org
Wed Jul 9 21:32:59 UTC 2008


-On [20080709 18:48], Tony Graham (Tony.Graham at MenteithConsulting.com) wrote:
>Just add $GLIB_LIBS to $LIBS before doing the test?

See patch.

The patch is threefold:

1) Get rid of unused GOBJECT_CFLAGS and convert them to the proper
   GLIB_CFLAGS. They're required, since the files in those directories
   include glib includes.

2) Get rid of end-of-file CFLAGS override. You were overriding the CFLAGS
   with GLIB_CFLAGS, which causes duplicate GLIB_CFLAGS later on in some
   cases. This way CFLAGS remains very pristine, reflecting only what the
   user or OS has passed along.

3) Temporarily add GLIB_CFLAGS and GLIB_LIBS to CFLAGS and LIBS, after
   storing them in scratch variables. Restore them after testing.

4) Add checks for /usr/local for CUnit. I seriously wonder if either
   autotools is just too stupid to automatically check /usr/local or whether
   I am missing something. (Also note that CUnit linking will break if CUnit
   was built with curses support, since we don't link to libcurses.) I get
   this on compilation at one point though:
   xmlroff/cunit/test-fo-doc.c:88: undefined reference to `fo_doc_gp_get_type'

It survives a clean build on my FreeBSD system (except for the CUnit stuff).

-- 
Jeroen Ruigrok van der Werven <asmodai(-at-)in-nomine.org> / asmodai
イェルーン ラウフロック ヴァン デル ウェルヴェン
http://www.in-nomine.org/ | http://www.rangaku.org/ | GPG: 2EAC625B
But Time, keeps flowing like a river (on and on)...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure.ac.diff
Type: text/x-diff
Size: 2411 bytes
Desc: not available
Url : http://lists.xmlroff.org/pipermail/xmlroff-list/attachments/20080709/3f9e261f/configure.ac.bin


More information about the xmlroff-list mailing list