[xmlroff] g_option_context_set_summary and BSDs

[Tony Graham]

On Wed, Jul 09 2008 22:32:59 +0100, asmodai at in-nomine.org wrote:
...
> The patch is threefold:

Thanks.  Added as #124.

> 1) Get rid of unused GOBJECT_CFLAGS and convert them to the proper
>    GLIB_CFLAGS. They're required, since the files in those directories
>    include glib includes.
>
> 2) Get rid of end-of-file CFLAGS override. You were overriding the CFLAGS
>    with GLIB_CFLAGS, which causes duplicate GLIB_CFLAGS later on in some
>    cases. This way CFLAGS remains very pristine, reflecting only what the
>    user or OS has passed along.

That CFLAGS used to have all the *_CFLAGS. but that got split apart
awhile ago.

> 3) Temporarily add GLIB_CFLAGS and GLIB_LIBS to CFLAGS and LIBS, after
>    storing them in scratch variables. Restore them after testing.

The thing I didn't want to do the last time you fixed this.  You've
convinced me.

> 4) Add checks for /usr/local for CUnit. I seriously wonder if either
>    autotools is just too stupid to automatically check /usr/local or whether
>    I am missing something. (Also note that CUnit linking will break if
>    CUnit

I was wondering much the same thing about the GLib libraries after your
previous email.

>    was built with curses support, since we don't link to libcurses.) I get
>    this on compilation at one point though:
>    xmlroff/cunit/test-fo-doc.c:88: undefined reference to `fo_doc_gp_get_type'

It could be missing a #include.

> It survives a clean build on my FreeBSD system (except for the CUnit stuff).

Thanks again.  It will go in the next release.

Regards,


Tony.

#124 http://xmlroff.org/ticket/124